Add property for given names#157
Closed
fdesoye wants to merge 2 commits into
Closed
Conversation
derek73
added a commit
that referenced
this pull request
Jun 29, 2026
* feat: add given_names attribute aggregating first and middle names (closes #157) Adds given_names (and given_names_list), the first name followed by all middle names, mirroring the existing surnames attribute (middle + last). Reimplemented fresh on current master from the approach in #157, which was based on a pre-refactor codebase and had drifted. Co-Authored-By: fdesoye <fdesoye@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * test: add empty-path and first-only tests for given_names; document pattern in AGENTS.md Covers the `or self.C.empty_attribute_default` branch (untested before this commit) and the no-middle boundary case. Also adds a note to AGENTS.md reminding future contributors to include an empty-path test for any new aggregate property. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: fdesoye <fdesoye@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like surnames, this feature will give you a list of all given names, i.e. all names except titles and last name.